I've added a DSL that wraps jQuery UI modals over in #1815. Maybe this could use that once it's merged.

Definitely - that looks great.

Are you happy with the changes to lib/active_admin/resource_controller/data_access.rb to accept start and end parameters?

Any suggestion to make it export the complete database?
On 28-Oct-2013 4:13 AM, "Hayden Ball" notifications@github.com wrote:

In response to #2449#2449,
I've created a modal dialog for setting start and end records when
exporting using download links.

The PR also modifies apply_pagination so that it respects export[:start]and
export[:end] parameters.

[image: screenshot from 2013-10-27 22 24 16]https://f.cloud.github.com/assets/1596233/1416562/2fb78b4c-3f59-11e3-9e21-f7b3d11bd1c4.png

Related: #1924 #1924

You can merge this Pull Request by running

git pull https://github.com/ball-hayden/active_admin 2449-better-exports

Or view, comment on, or merge it at:

#2626
Commit Summary

• Added export dialog, with start and end parameters.

File Changes

• A app/assets/javascripts/active_admin/pages/export_form.js.coffeehttps://github.com/Dialog to set start and end records for export #2626/files#diff-0(27)
• M app/assets/stylesheets/active_admin/_base.css.scsshttps://github.com/Dialog to set start and end records for export #2626/files#diff-1(1)
• A
  app/assets/stylesheets/active_admin/components/_export_form.css.scsshttps://github.com/Dialog to set start and end records for export #2626/files#diff-2(59)
• A features/index/export_pagination.featurehttps://github.com/Dialog to set start and end records for export #2626/files#diff-3(20)
• M lib/active_admin/resource_controller/data_access.rbhttps://github.com/Dialog to set start and end records for export #2626/files#diff-4(15)
• A lib/active_admin/view_helpers/export_dialog_helper.rbhttps://github.com/Dialog to set start and end records for export #2626/files#diff-5(23)
• M lib/active_admin/views/pages/index.rbhttps://github.com/Dialog to set start and end records for export #2626/files#diff-6(4)

Patch Links:

• https://github.com/gregbell/active_admin/pull/2626.patch
• https://github.com/gregbell/active_admin/pull/2626.diff

Set start to 1 and leave end blank.

I would not like to have a dialog asking for records
On 28-Oct-2013 4:13 AM, "Hayden Ball" notifications@github.com wrote:

In response to #2449#2449,
I've created a modal dialog for setting start and end records when
exporting using download links.

The PR also modifies apply_pagination so that it respects export[:start]and
export[:end] parameters.

[image: screenshot from 2013-10-27 22 24 16]https://f.cloud.github.com/assets/1596233/1416562/2fb78b4c-3f59-11e3-9e21-f7b3d11bd1c4.png

Related: #1924 #1924

You can merge this Pull Request by running

git pull https://github.com/ball-hayden/active_admin 2449-better-exports

Or view, comment on, or merge it at:

#2626
Commit Summary

• Added export dialog, with start and end parameters.

File Changes

• A app/assets/javascripts/active_admin/pages/export_form.js.coffeehttps://github.com/Dialog to set start and end records for export #2626/files#diff-0(27)
• M app/assets/stylesheets/active_admin/_base.css.scsshttps://github.com/Dialog to set start and end records for export #2626/files#diff-1(1)
• A
  app/assets/stylesheets/active_admin/components/_export_form.css.scsshttps://github.com/Dialog to set start and end records for export #2626/files#diff-2(59)
• A features/index/export_pagination.featurehttps://github.com/Dialog to set start and end records for export #2626/files#diff-3(20)
• M lib/active_admin/resource_controller/data_access.rbhttps://github.com/Dialog to set start and end records for export #2626/files#diff-4(15)
• A lib/active_admin/view_helpers/export_dialog_helper.rbhttps://github.com/Dialog to set start and end records for export #2626/files#diff-5(23)
• M lib/active_admin/views/pages/index.rbhttps://github.com/Dialog to set start and end records for export #2626/files#diff-6(4)

Patch Links:

• https://github.com/gregbell/active_admin/pull/2626.patch
• https://github.com/gregbell/active_admin/pull/2626.diff

@abhimediratta if you have a better idea then please discuss it over in #2449, or even open your own PR if you know exactly what you want.

Please let me know if there is a full export option. I have raised a query
in #2449.
On 30-Oct-2013 7:27 PM, "Sean Linsley" notifications@github.com wrote:

@abhimediratta https://github.com/abhimediratta if you have a better
idea then please discuss it over in #2449#2449,
or even open your own PR if you know exactly what you want.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2626#issuecomment-27390740
.

Yeah I saw that, but "open source" doesn't mean "ask for features from random people on the internet and just expect them to do it". Right now no such feature exists, and we're working to change that. But if you're going to complain about the work done by @ball-hayden then you should suggest an alternative and/or implement it.

I will start working on it. I apologize, I thought there must have been a
workaround for it.

Perhaps an idea would be to have a config option to either:

• Export current records (as it is at the moment)
• Export all records
• Show a dialog

Do you think it would be worth having a clear "all" option in the dialog (radio button all / select records)?

@ball-hayden I like the thought of this, but I would like to see an inheritable setting that we could specify for the app, per namespace, or per resource with the options you mentioned above.

I definitely don't want the default behavior to be a modal popup for my projects either :)

While I'm not in love with the thought of a modal popup either, I think in any way promising to the user or developer that Active Admin can handle exporting all records is the wrong way to go. There either needs to be a hard limit like we had before, or some UI to help the user export the data in batches.

Slightly messily, I've rebased onto #1815 to use @seanlinsley's dialog DSL.

I'm going to have a look at adding configuration options.

Coverage decreased (-0.22%) when pulling 704158d on ball-hayden:2449-better-exports into 37048c7 on gregbell:master.

I'm going to close this, as #3038 seems to be a much better solution.